Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Masonry: Enable whitespaceThreshold prop #3825

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

bryamrrr
Copy link
Contributor

Summary

What changed?

We are enabling whitespace threshold so it can be used to position multicolumn modules without excessive work to find an optimal whitespace.

Why?

This is a follow-up to #3817.

@bryamrrr bryamrrr marked this pull request as ready for review October 24, 2024 16:45
@bryamrrr bryamrrr requested a review from a team as a code owner October 24, 2024 16:45
Copy link

netlify bot commented Oct 24, 2024

Deploy Preview for gestalt ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 21cb63c
🔍 Latest deploy log https://app.netlify.com/sites/gestalt/deploys/671a78d41db5a00008595974
😎 Deploy Preview https://deploy-preview-3825--gestalt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@liuyenwei liuyenwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note for anyone else reviewing: whitespaceThreshold already exists in the actual layout function(s). This just makes it externally configurable

@manvoid manvoid added the patch release Patch release label Oct 24, 2024
@manvoid manvoid merged commit e61f6df into pinterest:master Oct 24, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch release Patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants